Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place a system metadata stamp on readme chart #405

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Place a system metadata stamp on readme chart #405

merged 4 commits into from
Nov 20, 2024

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Nov 20, 2024

This also reorients the data file itself to be structured as:

{
  "experiments":
    [
      # list of individual experiments
    ]
  "system_metadata":
    {
      # key-value pairs of metadata
    }
}

Because this changes the data file, I'll wait until the current experiments are done, and then I'll merge things manually.

@scotts scotts requested a review from ahmadsharif1 November 20, 2024 20:16
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 20, 2024
@scotts scotts marked this pull request as ready for review November 20, 2024 20:28
ahmadsharif1
ahmadsharif1 reviewed Nov 20, 2024
View reviewed changes
benchmarks/decoders/generate_readme_data.py
}
)
data_for_writing = {
"experiments": results,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why not call these results?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading a data file, I find it more clear to see "experiments" and "system_metadata". But in the code, I think "results" is more clear that it's the return value of running the experiments.

@scotts scotts merged commit fd4c288 into pytorch:main Nov 20, 2024
37 of 38 checks passed
@scotts scotts deleted the system_stamp branch November 20, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadsharif1 ahmadsharif1 ahmadsharif1 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scotts @ahmadsharif1 @facebook-github-bot